Refactor internals module part 3
#1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1431 +/- ##
=======================================
Coverage 91.84% 91.84%
=======================================
Files 38 38
Lines 17628 17571 -57
=======================================
- Hits 16190 16138 -52
+ Misses 1438 1433 -5 ☔ View full report in Codecov by Sentry. |
djc
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit makes the
iso_week_from_yoffunction a method onIsoWeek.The next changes it to consume an
ordinalandyear_flagsinstead ofOf, and inlines the functionality that was inOf::isoweekdate_raw.The others move over the
weekdayandyear_flagsgetters toNaiveDate.